Support 'exports' field in package.json of published modules.#1392
Merged
Perryvw merged 4 commits intoTypeScriptToLua:masterfrom Feb 5, 2023
pilaoda:master
Merged
Support 'exports' field in package.json of published modules.#1392Perryvw merged 4 commits intoTypeScriptToLua:masterfrom pilaoda:master
Perryvw merged 4 commits intoTypeScriptToLua:masterfrom
pilaoda:master
Conversation
Perryvw
reviewed
Feb 5, 2023
| tstl.transpileProject(path.join(projectPath, "dependency1-ts", "tsconfig.json")); | ||
|
|
||
| // Install dependencies. This will create node_modules folder with dependency1-ts in it. | ||
| execSync("npm i", { cwd: appPath }); |
Member
There was a problem hiding this comment.
I don't want to run npm during tests for all kind of reasons (dependency, security, flakyness etc). Please just put dependency1 in node_modules beforehand and compile there, or commit a symlink or something like that.
Perryvw
reviewed
Feb 5, 2023
| @@ -0,0 +1,28 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Could this file be removed now that we no longer do a npm install?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1389 Fix problem 1