Skip to content

Fix crash on invalid call extension operator use#1386

Merged
Perryvw merged 4 commits intoTypeScriptToLua:masterfrom
GlassBricks:language-extension-error
Jan 22, 2023
Merged

Fix crash on invalid call extension operator use#1386
Perryvw merged 4 commits intoTypeScriptToLua:masterfrom
GlassBricks:language-extension-error

Conversation

@GlassBricks
Copy link
Copy Markdown
Contributor

Fixes #1385.

This also:

  • Fixes using operator call extensions with preceding statements
  • Adds a diagnostic if a spread element is used in call extensions, which is not supported

Copy link
Copy Markdown
Member

@Perryvw Perryvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright, please resolve the conflict so this can be merged

…error

# Conflicts:
#	test/unit/__snapshots__/optionalChaining.spec.ts.snap
@GlassBricks
Copy link
Copy Markdown
Contributor Author

GlassBricks commented Jan 22, 2023

I did a merge from master locally (so I can verify that tests still work when resolving conflicts).

@Perryvw Perryvw merged commit 7e8c2fb into TypeScriptToLua:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling an operator method without an argument causes a crash

2 participants