Skip to content

Conversation

@Cheatoid
Copy link
Contributor

@Cheatoid Cheatoid commented Oct 3, 2022

This function would run after Lua files have been written to disk (in order to allow plugins to perform post-build tasks such as optimizing/minifying/obfuscating/bytecode-compilation/etc).

This function would run after Lua files have been written to disk (in order to allow plugins to perform post-build tasks such as optimizing/minifying/obfuscating/bytecode-compilation/etc).
@lolleko
Copy link
Member

lolleko commented Oct 4, 2022

Not sure if this should be part of TSTL. There are already JS build systems that incorporate that functionality (e.g. gulp, grunt, make). Even a simple shell or npm script would work fine.

Especially because all the tasks mentioned don't need any information from TSTL and can just be standalone programs/scripts.

optimizing/minifying/obfuscating/bytecode-compilation/etc

@Cheatoid
Copy link
Contributor Author

Cheatoid commented Oct 4, 2022

@lolleko Pinged you on Discord, see the relevant chat; the purpose of afterEmit is to remove annoyance of having to run npm script manually all the time, in other words, I need a hook which will run after transpiled files have been written to disk to allow third-party tools to work upon those files, and here comes the key part - it also has to be incremental friendly (tstl --watch). I was told by Perry that this should be incremental friendly, hence afterEmit PR.

@Perryvw Perryvw merged commit bf87953 into TypeScriptToLua:master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants