Lua 5.0: Fix bad unpack() call in SparseArraySpread#1347
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Sep 17, 2022
YoRyan:fix-lua50-unpack
Merged
Lua 5.0: Fix bad unpack() call in SparseArraySpread#1347Perryvw merged 1 commit intoTypeScriptToLua:masterfrom YoRyan:fix-lua50-unpack
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
YoRyan:fix-lua50-unpack
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the 5.0 target, we are currently transpiling the SparseArraySpread lualib feature as:
The
nilargument causes runtime errors and should not be there; unpack() takes 3 arguments. Or, rather, it does in all versions of Lua except 5.0, which does not support the optional i and j arguments that specify the start and end of the unpacked slice.So we need to add a polyfill that supports i and j, and also convinces the type checker that it's okay to call unpack() without a leading
nil.