Update VS Code development container configuration#1344
Merged
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom Sep 3, 2022
YoRyan:update-devcontainer
Merged
Update VS Code development container configuration#1344Perryvw merged 2 commits intoTypeScriptToLua:masterfrom YoRyan:update-devcontainer
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
YoRyan:update-devcontainer
Conversation
Bump Node version, delete obsolete setting, fix npm error, run as a non-root user.
Perryvw
reviewed
Sep 3, 2022
.devcontainer/devcontainer.json
Outdated
| "esbenp.prettier-vscode" | ||
| ], | ||
| "postCreateCommand": "npm ci" | ||
| "postCreateCommand": "npm ci --legacy-peer-deps", |
Member
There was a problem hiding this comment.
legacy-peer-deps should not be in here, this is something I'm looking to fix, not something we want to keep
Contributor
Author
There was a problem hiding this comment.
Ok, no problem to remove it. The post-create command failing in the meantime is a very minor inconvenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump to Node 18, delete the obsolete shell preference, fix npm error with the post-install command, and run as a non-root user.