Skip to content

Sourcemap super call #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 3 commits into from
Aug 3, 2022
Merged

Sourcemap super call #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d18b8
Fix super call source mapping
Perryvw Aug 3, 2022
987d261
Fixed some more missing source mappings in call expressions
Perryvw Aug 3, 2022
ff83ce8
Remove stray debug
Perryvw Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/transformation/visitors/call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ function transformPropertyCall(
if (calledMethod.expression.kind === ts.SyntaxKind.SuperKeyword) {
// Super calls take the format of super.call(self,...)
const parameters = transformArguments(context, node.arguments, signature, ts.factory.createThis());
return lua.createCallExpression(context.transformExpression(node.expression), parameters);
return lua.createCallExpression(context.transformExpression(node.expression), parameters, node);
}

const signatureDeclaration = signature?.getDeclaration();
Expand All @@ -207,7 +207,7 @@ function transformElementCall(context: TransformationContext, node: ts.CallExpre
} else {
// No context
const [expression, parameters] = transformCallAndArguments(context, node.expression, node.arguments, signature);
return lua.createCallExpression(expression, parameters);
return lua.createCallExpression(expression, parameters, node);
}
}

Expand Down Expand Up @@ -257,7 +257,8 @@ export const transformCallExpression: FunctionVisitor<ts.CallExpression> = (node
context.transformExpression(ts.factory.createSuper()),
lua.createStringLiteral("____constructor")
),
parameters
parameters,
node
);
}

Expand Down
1 change: 0 additions & 1 deletion test/transpile/module-resolution.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,6 @@ test("supports complicated paths configuration", () => {
util.testProject(projectTsConfig)
.setMainFileName(mainFile)
.setOptions({ luaBundle: "bundle.lua", luaBundleEntry: mainFile })
.debug()
.expectToEqual({ foo: 314, bar: 271 });
});

Expand Down