Fixes for Optimize PR#1312
Merged
Perryvw merged 4 commits intoTypeScriptToLua:masterfrom Jul 19, 2022
Merged
Conversation
GlassBricks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following things that were broken with the last PR:
Fixes
function.apply(...)and similar calls, when the function is declared using an explicit arrow-function type (const foo: (args)=>ret).Fixes an optimization with language-extensions detection (broken as in didn't actually optimize, not wrong behavior). Another 6%
transpiletime speedup.Fixes optional chaining breaking language extensions. This wasn't caught in the tests previously before because strictNullChecks needs to be on.