Merged
Conversation
Perryvw
reviewed
Jun 24, 2022
src/transformation/visitors/call.ts
Outdated
| if (ts.nodeIsSynthesized(node.expression)) { | ||
| // this includes JSX createElement calls | ||
| // For this we use noImplicitSelf option | ||
| return !context.options.noImplicitSelf; |
Member
There was a problem hiding this comment.
Can't we just use this return for any node without declaration? In what case does this fail?
Contributor
Author
There was a problem hiding this comment.
I just checked and that works, will change.
I somehow recall that doing that broke some tests, I guess that is (no longer?) the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1292, which was broken by #1282
To still keep #1262, I couldn't find an elegant way to detect jsx createElement calls specifically. Instead I found a condition that tells if a call is probably jsx createElement (see changes in call.ts).
Maybe the best thing to do is to revert #1282, and document that the
thisparameter is always required for jsxcreateElement.