Reduce use of temp variables#1291
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Jun 24, 2022
Merged
Conversation
GlassBricks
changed the title
Member
|
Could you give an example of a case that is not translated differently? |
Contributor
Author
|
Here are some cases where unnecessary temps are used. Note: with the latest commit, some more temps may be used, but I guess that covers the case where evaluating |
Member
|
I know the validity of these changes is probably already ensured by the existing tests. But I would feel better if we had some explicit functional tests, for your optimization cases, if possible. |
Contributor
Author
|
Sure, I just added some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the use of temp variables by using
moveToPrecedingTempinstead of always using a temp. This was done for some cases of assigment and in destructuring declarations.Additionally, the
thiskeyword (which is read-only) is no longer moved to a temp variable.