noImplicitGlobalVariables compiler option#1269
Merged
Perryvw merged 5 commits intoTypeScriptToLua:masterfrom May 28, 2022
Zamiell:noImplicitGlobalVariables
Merged
noImplicitGlobalVariables compiler option#1269Perryvw merged 5 commits intoTypeScriptToLua:masterfrom Zamiell:noImplicitGlobalVariables
Perryvw merged 5 commits intoTypeScriptToLua:masterfrom
Zamiell:noImplicitGlobalVariables
Conversation
Perryvw
reviewed
May 28, 2022
| `.expectToHaveNoDiagnostics(); | ||
|
|
||
| const transpiledFile = builder.getLuaResult().transpiledFiles[0]; | ||
| util.assert(transpiledFile !== undefined); |
Member
There was a problem hiding this comment.
These asserts should just be expect.toBeDefined()
Perryvw
reviewed
May 28, 2022
| `.expectToHaveNoDiagnostics(); | ||
|
|
||
| const transpiledFile = builder.getLuaResult().transpiledFiles[0]; | ||
| util.assert(transpiledFile !== undefined); |
Member
There was a problem hiding this comment.
These asserts should just be expect.toBeDefined()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1119.
Pretty self explanatory, tiny PR.
I guess I need to do website PR too?