fix: debug.traceback of loadstring get unknown file #1259#1260
fix: debug.traceback of loadstring get unknown file #1259#1260Perryvw merged 4 commits intoTypeScriptToLua:masterfrom pilaoda:master
Conversation
Perryvw
left a comment
Perryvw
left a comment
There was a problem hiding this comment.
Looks alright, could you see if you can add a test that fails without your fix and fix the linter errors by running npm run fix:prettier ?
|
Can you add a test that would fail without your changes, but passes on your branch? Maybe something throwing an error in loadstring like your issue mentions. Add it here: https://github.com/TypeScriptToLua/TypeScriptToLua/blob/master/test/unit/printer/sourcemaps.spec.ts#L286 |
This test is really complicated. I tried my best. |
| test("loadstring sourceMapTraceback gives traceback", () => { | ||
| const strCodeBuilder = util.testModule` | ||
| function bar() { | ||
| const trace = (debug.traceback as (this: void)=>string)(); | ||
| return trace; | ||
| } | ||
| return bar(); | ||
| `.setOptions({ sourceMapTraceback: true, luaTarget: LuaTarget.Lua51 }); | ||
|
|
||
| const strCode = strCodeBuilder.getMainLuaCodeChunk(); | ||
| const file = ` | ||
| const luaCode: string = \`${strCode}\`; | ||
| return (loadstring as (this: void, string: string, chunkname?: string) => LuaMultiReturn<[() => any] | [undefined, string]>) | ||
| (luaCode, "foo.lua")() | ||
| `; | ||
| const builder = util.testModule` | ||
| return (require as (this: void, modname: string) => any)("foo"); | ||
| ` | ||
| .addExtraFile("foo.ts", file) | ||
| .setOptions({ sourceMapTraceback: true, luaTarget: LuaTarget.Lua51 }); | ||
|
|
||
| const traceback = builder.getLuaExecutionResult(); | ||
| expect(traceback).toContain("foo.ts"); | ||
| }); |
There was a problem hiding this comment.
This looks way too complicated, couldn't you just do something like:
const builder = util.testFunction`
return loadstring(
"return debug.traceback();",
"foo.lua"
)();
`
.setTsHeader("declare function loadstring(this: void, str: string, chunkName: string): () => unknown;")
.setOptions({ sourceMapTraceback: true, luaTarget: LuaTarget.Lua51 });
const traceback = builder.getLuaExecutionResult();
expect(traceback).toContain("foo.ts");There was a problem hiding this comment.
This looks way too complicated, couldn't you just do something like:
const builder = util.testFunction` return loadstring( "return debug.traceback();", "foo.lua" )(); ` .setTsHeader("declare function loadstring(this: void, str: string, chunkName: string): () => unknown;") .setOptions({ sourceMapTraceback: true, luaTarget: LuaTarget.Lua51 }); const traceback = builder.getLuaExecutionResult(); expect(traceback).toContain("foo.ts");
This is intentional.
The compiled lua code and sourcemap info should be passed into the loadstring together , otherelse the foo.lua could not be mapped back to foo.ts .
There was a problem hiding this comment.
I played around with it a bit, a much nicer test seems to be:
const loadStrCode = transpileString(
`function bar() {
const trace = (debug.traceback as (this: void)=>string)();
return trace;
}
return bar();`,
{ sourceMapTraceback: true, luaTarget: LuaTarget.Lua51 }
).file?.lua;
const builder = util.testModule`
const luaCode = \`${loadStrCode}\`;
return loadstring(luaCode, "foo.lua")();
`
.setTsHeader("declare function loadstring(this: void, string: string, chunkname: string): () => unknown")
.setOptions({ sourceMapTraceback: true, luaTarget: LuaTarget.Lua51 });
const traceback = builder.getLuaExecutionResult();
expect(traceback).toContain("foo.ts");Seems to work and is much neater.
There was a problem hiding this comment.
Cool. I will commit with your nicer test.
2 participants
Assume the chunkname is the lua path, and replace the traceback substring [string "xx/xx.lua"]:22 to xx/xx.ts:10