Add new option to bypass 5.1 try/catch in async/await precaution#1247
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Apr 2, 2022
Merged
Conversation
Member
|
Looks fine to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1158
Adds a very specific option to allow TSTL to proceed with transforming try/catch in async/await functions
lua51AllowTryCatchInAsyncAwait(boolean) (false by default)I figured
lua51in the name to come first because this only has an effect on Lua 5.1 and isn't needed in any other targetsI can add more to this PR if needed just wanted to get an idea if this is the kind of solution expected 🤔
Also planning to add some more details to the wiki about what specifically in the language we're looking for so that someone can figure out if this is a switch they should enable