Skip to content

Added BeforeEmit plugin hook#1239

Merged
Perryvw merged 2 commits intomasterfrom
beforeemit-hook
Mar 20, 2022
Merged

Added BeforeEmit plugin hook#1239
Perryvw merged 2 commits intomasterfrom
beforeemit-hook

Conversation

@Perryvw
Copy link
Copy Markdown
Member

@Perryvw Perryvw commented Mar 19, 2022

Closes #1236

@Perryvw Perryvw requested a review from lolleko March 19, 2022 20:07
@GlassBricks
Copy link
Copy Markdown
Contributor

GlassBricks commented Mar 19, 2022

@Perryvw Just tested, this does not fix #1236 yet. I commented on that issue with more details.

@Perryvw
Copy link
Copy Markdown
Member Author

Perryvw commented Mar 19, 2022

@Perryvw Just tested, this does not fix #1236 yet. I commented on that issue with more details.

Although I agree with your comments on that issue, that is a different problem from what #1236 is about. The question is how to place a comment at the top of a bundle file/make modifications to the final bundle, and beforeEmit allows you to do exactly that, although it could indeed break the source map.

@Perryvw Perryvw merged commit 1cdd6b0 into master Mar 20, 2022
@Perryvw Perryvw deleted the beforeemit-hook branch March 20, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

afterPrint from the latest patch doesn't work

2 participants