Fix preceding statements with ternary operator#1234
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Mar 17, 2022
Merged
Fix preceding statements with ternary operator#1234Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
Conversation
Perryvw
reviewed
Mar 16, 2022
| return { result, i }; | ||
| ` | ||
| .setOptions({ | ||
| strictNullChecks: true, |
Member
There was a problem hiding this comment.
Why is this option required here, I don't see any undefineds/nulls in the tests?
Contributor
Author
There was a problem hiding this comment.
Without it, the test doesn't start as failing and detect the issue:
The type number with no strict null checks may be null and therefore falsy, so the if statement was used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1231