Lualib modules using a plugin to generate lualib#1227
Merged
Conversation
* fix lualib-build * Finish lualib modules via plugin implementation * Include build-lualib.ts
Contributor
|
Question: Is it possible to use the new |
Member
Author
Yes, that is exaclty what the added test for afterPrint does. |
Contributor
|
Woot! 🎉 |
lolleko
reviewed
Mar 13, 2022
lolleko
approved these changes
Mar 15, 2022
Member
Author
|
Trying to re-trigger checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two big changes:
Lualib files are now modules
Plugins now provide
beforeTransformandafterEmithooksTo generate the required lualib files we used a plugin that required some extra hooks. Because of this we introduced two extra TSTL plugin functions:
beforeTansform
This function on the plugin is called after gathering the TypeScript program and options, but before starting the transformation process. This can be used to set up stuff in the plugin, or to modify the program/options that the transpiler will act on.
afterPrint
This function on the plugin is run after the printing of Lua has completed. It provides the output array as one of its parameters, which can be used to modify the final output before finishing the emit.