Improve expression statement handling and language extensions calls#1201
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Jan 4, 2022
Merged
Conversation
lolleko
requested changes
Jan 2, 2022
lolleko
reviewed
Jan 3, 2022
lolleko
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes go together:
With preceding statements, table function language extensions (
TableGet,TableSet, etc.) can now be used as expressions.TableDeletefunctions are typed to returnboolean, but previously the return value could never be used; these now returntrueto be similar to delete expressions. Other methods returnnil.Additionally, I fixed table function extensions that use preceding statements or spread arguments. This required some refactoring; The result is based on
transformBuiltinCallExpression. This additionally avoids unnecessary calls togetTableExtensionKindForCalland fixes some other minor bugs that I found.transformExpressionStatement now omits the statement entirely if the inner expression result is "synthetic" with no side effects (a temp variable, or a literal without a source map position). This removes unnecessary
local ____ = ...in several cases (e.g.a?.b()). This also decouples transformExpressionStatement from other language features: now table call language extensions can be transformed as an expression, and its return value (nilortrue) is omitted when in an expression statement (not used).voidexpressions now also share some of this logic to omit unecessarylocal ____ = ....