Fix optimized vararg spread with casts#1193
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Dec 21, 2021
Merged
Conversation
Perryvw
reviewed
Dec 20, 2021
| const catchParameter = statement.catchClause.variableDeclaration | ||
| ? transformIdentifier(context, statement.catchClause.variableDeclaration.name as ts.Identifier) | ||
| : undefined; | ||
| const catchParameters = () => (catchParameter ? [lua.cloneIdentifier(catchParameter)] : []); |
Member
There was a problem hiding this comment.
What happened here, this seems like the change from the other branch? Guess you need to merge master into this branch.
Contributor
Author
There was a problem hiding this comment.
Yeah, somehow those changes made it here.
I just force pushed a new commit without those changes
Also fixes for other outer expressions.
GlassBricks
force-pushed
the
optimized-vararg-spread-with-cast
branch
from
b63bf86 to
511161d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1143.
Also fixes for other outer expressions.