Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/transformation/utils/export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ export function hasDefaultExportModifier(node: ts.Node): boolean {
return (node.modifiers ?? []).some(modifier => modifier.kind === ts.SyntaxKind.DefaultKeyword);
}

export const createDefaultExportIdentifier = (original: ts.Node): lua.Identifier =>
lua.createIdentifier("default", original);
export function hasExportModifier(node: ts.Node): boolean {
return (node.modifiers ?? []).some(modifier => modifier.kind === ts.SyntaxKind.ExportKeyword);
}

export const createDefaultExportStringLiteral = (original: ts.Node): lua.StringLiteral =>
export const createDefaultExportStringLiteral = (original?: ts.Node): lua.StringLiteral =>
lua.createStringLiteral("default", original);

export function getExportedSymbolDeclaration(symbol: ts.Symbol): ts.Declaration | undefined {
Expand Down Expand Up @@ -142,3 +143,7 @@ export function createExportedIdentifier(

return lua.createTableIndexExpression(exportTable, lua.createStringLiteral(identifier.text));
}

export function createDefaultExportExpression(node: ts.Node): lua.AssignmentLeftHandSideExpression {
return lua.createTableIndexExpression(createExportsIdentifier(), createDefaultExportStringLiteral(node), node);
}
14 changes: 12 additions & 2 deletions src/transformation/visitors/class/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import { FunctionVisitor, TransformationContext } from "../../context";
import { AnnotationKind, getTypeAnnotations } from "../../utils/annotations";
import { annotationRemoved } from "../../utils/diagnostics";
import {
createDefaultExportIdentifier,
createDefaultExportExpression,
createExportedIdentifier,
hasDefaultExportModifier,
hasExportModifier,
isSymbolExported,
} from "../../utils/export";
import { createSelfIdentifier, unwrapVisitorResult } from "../../utils/lua-ast";
Expand All @@ -30,7 +31,7 @@ import { getExtendedNode, getExtendedType, isStaticNode } from "./utils";
export const transformClassDeclaration: FunctionVisitor<ts.ClassLikeDeclaration> = (declaration, context) => {
// If declaration is a default export, transform to export variable assignment instead
if (hasDefaultExportModifier(declaration)) {
const left = createExportedIdentifier(context, createDefaultExportIdentifier(declaration));
const left = createDefaultExportExpression(declaration);
const right = transformClassAsExpression(declaration, context);
return [lua.createAssignmentStatement(left, right, declaration)];
}
Expand Down Expand Up @@ -220,6 +221,15 @@ function transformClassLikeDeclaration(
);
const decoratingStatement = lua.createAssignmentStatement(localClassName, decoratingExpression);
result.push(decoratingStatement);

if (hasExportModifier(classDeclaration)) {
const exportExpression = hasDefaultExportModifier(classDeclaration)
? createDefaultExportExpression(classDeclaration)
: createExportedIdentifier(context, className);

const classAssignment = lua.createAssignmentStatement(exportExpression, localClassName);
result.push(classAssignment);
}
}

superInfo.pop();
Expand Down
9 changes: 4 additions & 5 deletions src/transformation/visitors/modules/export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as lua from "../../../LuaAST";
import { assert } from "../../../utils";
import { FunctionVisitor, TransformationContext } from "../../context";
import {
createDefaultExportIdentifier,
createDefaultExportExpression,
createDefaultExportStringLiteral,
createExportedIdentifier,
} from "../../utils/export";
Expand Down Expand Up @@ -114,10 +114,9 @@ function transformExportSpecifier(context: TransformationContext, node: ts.Expor
const exportedExpression = createShorthandIdentifier(context, exportedSymbol, exportedIdentifier);

const isDefault = isDefaultExportSpecifier(node);
const identifierToExport = isDefault
? createDefaultExportIdentifier(node)
: transformIdentifier(context, node.name);
const exportAssignmentLeftHandSide = createExportedIdentifier(context, identifierToExport);
const exportAssignmentLeftHandSide = isDefault
? createDefaultExportExpression(node)
: createExportedIdentifier(context, transformIdentifier(context, node.name));

return lua.createAssignmentStatement(exportAssignmentLeftHandSide, exportedExpression, node);
}
Expand Down
53 changes: 53 additions & 0 deletions test/unit/classes/decorators.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,56 @@ describe("Decorators /w descriptors", () => {
}
);
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1149
test("exported class with decorator", () => {
util.testModule`
import { MyClass } from "./other";
const inst = new MyClass();
export const result = inst.foo();
`
.addExtraFile(
"other.ts",
`function myDecorator(target: {new(): any}) {
return class extends target {
foo() {
return "overridden";
}
}
}

@myDecorator
export class MyClass {
foo() {
return "foo";
}
}`
)
.expectToEqual({ result: "overridden" });
});

test("default exported class with decorator", () => {
util.testModule`
import MyClass from "./other";
const inst = new MyClass();
export const result = inst.foo();
`
.addExtraFile(
"other.ts",
`function myDecorator(target: {new(): any}) {
return class extends target {
foo() {
return "overridden";
}
}
}

@myDecorator
export default class {
foo() {
return "foo";
}
}`
)
.expectToEqual({ result: "overridden" });
});