Conversation
tomblind
reviewed
Oct 24, 2021
Collaborator
tomblind
left a comment
tomblind
left a comment
There was a problem hiding this comment.
It might be worth stripping the IIFE if the void expression is an expression statement, especially since a common use of the keyword is to formally declare that a call to an async function should not be awaited.
Contributor
|
It might also be worth replacing the IIFE with just It may be noted that the IIFE can be omitted if we use preceding statements. Another weird option is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the void expression: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/void
This doubly fixes #1102: It no longer crashes on the unsupportedNodeKind because we now correctly use ts.getOriginalNode, but also this expression is not unsupported anymore :)