Skip to content

Made source file paths in sourcemaps relative again#1140

Merged
Perryvw merged 9 commits intomasterfrom
relative-sourcecemap-paths
Sep 27, 2021
Merged

Made source file paths in sourcemaps relative again#1140
Perryvw merged 9 commits intomasterfrom
relative-sourcecemap-paths

Conversation

@Perryvw
Copy link
Copy Markdown
Member

@Perryvw Perryvw commented Sep 19, 2021

Fixes #1131

@Perryvw Perryvw requested a review from tomblind September 19, 2021 19:12
Copy link
Copy Markdown
Collaborator

@tomblind tomblind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sources should contain paths relative to the source map itself (see here), not the project root, since the consumer may have no idea what that even is. We'll need to handle outDir and sourceRoot compiler options to ensure this relative path is correct based on where the map is actually output. Here is our old implementation, which I believe covered these cases.

@Perryvw Perryvw merged commit 1f9be79 into master Sep 27, 2021
@Perryvw Perryvw deleted the relative-sourcecemap-paths branch September 27, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source maps should be generated with relative paths

2 participants