Use ts.transformJsx instead for jsx. #1123
Merged
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom Sep 8, 2021
Merged
Conversation
Contributor
Author
|
There are some unnecessary diff due to unnecessary formatting by my IDE, fixing... |
…ptToLua#1052)". This reverts commit 987899c.
Perryvw
reviewed
Sep 7, 2021
Member
Perryvw
left a comment
Perryvw
left a comment
There was a problem hiding this comment.
Very nice, I'll gladly get rid of our custom jsx handling, this seems like the better solution to me.
Contributor
Author
|
Just remember to put the breaking change into the release notes:
|
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Use `ts.transformJsx` instead for jsx. Reverts "JSX support (TypeScriptToLua#1052)". This reverts commit 987899c. * Add comment explaining overriding compiler options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially reverts commit 987899c "JSX support (#1052)".
This is an experiment with using typescript's own transformer instead of our own for JSX support. I think this could be better than what we are currently doing.
All JSX tests still pass, however, there is a backwards incompatibility: React.createElement now needs a
selfparameter, where it didn't previously. I couldn't find a good way to control this.Advantages:
Disadvantages: