Skip to content

support for global $vararg in bundles#1107

Merged
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
tomblind:vararg-bundle-fix
Aug 30, 2021
Merged

support for global $vararg in bundles#1107
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
tomblind:vararg-bundle-fix

Conversation

@tomblind
Copy link
Copy Markdown
Collaborator

fixes #1048

To emulate normal Lua functionality, the entry point receives the global vararg and sub-modules receive their own name when evaluating $vararg (...).

fixes TypeScriptToLua#1048
To emulate normal Lua functionality, the entry point receives the global vararg and sub-modules receive their own name when evaluating `$vararg` (`...`).
@tomblind tomblind requested review from Perryvw and lolleko August 27, 2021 14:54
@Perryvw Perryvw merged commit 12cce12 into TypeScriptToLua:master Aug 30, 2021
sanikoyes pushed a commit to sanikoyes/TypeScriptToLua that referenced this pull request Sep 24, 2021
* support for global $vararg in bundles
fixes TypeScriptToLua#1048
To emulate normal Lua functionality, the entry point receives the global vararg and sub-modules receive their own name when evaluating `$vararg` (`...`).

* using dummy vararg when wrapping bundle tests to prevent lua error

Co-authored-by: Tom <tomblind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top level [...$vararg] in bundled file not resolving to command line arguments

2 participants