fix for vararg access in async functions#1096
Merged
Perryvw merged 1 commit intoTypeScriptToLua:async-awaitfrom Aug 20, 2021
Merged
fix for vararg access in async functions#1096Perryvw merged 1 commit intoTypeScriptToLua:async-awaitfrom
Perryvw merged 1 commit intoTypeScriptToLua:async-awaitfrom
Conversation
Perryvw
added a commit
that referenced
this pull request
Aug 20, 2021
* Initial lualib promise class implementation * First promise tests * More promise tests * Promise class implementation * Implemented Promise.all * Promise.any * Promise.race * Promise.allSettled * fix prettier * Add promise example usage test * Added missing lualib dependencies for PromiseConstructor functions * Immediately call then/catch/finally callbacks on promises that are already resolved * Transform all references to Promise to __TS__Promise * PR feedback * Removed incorrect asyncs * Add test for direct chaining * Add test for finally and correct wrong behavior it caught * Added test throwing in parallel and chained then onFulfilleds * Fixed pull request link in ArrayIsArray lualib comment * Initial async await * Disallow await in top-level scope * Add await rejection test * Give await the correct lualib dependencies * use coroutine.status instead of lastData * Better top level await check * Add tests for async lambdas and throws in async functions * Moved toplevel await check to transformAwaitExpression and removed superfluous try/catch * fix for vararg access in async functions (#1096) Co-authored-by: Tom <tomblind@users.noreply.github.com> Co-authored-by: Tom <26638278+tomblind@users.noreply.github.com> Co-authored-by: Tom <tomblind@users.noreply.github.com>
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Initial lualib promise class implementation * First promise tests * More promise tests * Promise class implementation * Implemented Promise.all * Promise.any * Promise.race * Promise.allSettled * fix prettier * Add promise example usage test * Added missing lualib dependencies for PromiseConstructor functions * Immediately call then/catch/finally callbacks on promises that are already resolved * Transform all references to Promise to __TS__Promise * PR feedback * Removed incorrect asyncs * Add test for direct chaining * Add test for finally and correct wrong behavior it caught * Added test throwing in parallel and chained then onFulfilleds * Fixed pull request link in ArrayIsArray lualib comment * Initial async await * Disallow await in top-level scope * Add await rejection test * Give await the correct lualib dependencies * use coroutine.status instead of lastData * Better top level await check * Add tests for async lambdas and throws in async functions * Moved toplevel await check to transformAwaitExpression and removed superfluous try/catch * fix for vararg access in async functions (TypeScriptToLua#1096) Co-authored-by: Tom <tomblind@users.noreply.github.com> Co-authored-by: Tom <26638278+tomblind@users.noreply.github.com> Co-authored-by: Tom <tomblind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
took a stab at fixing the vararg issues