Fix context failed to be resolved due to parentheses#1095
Merged
Conversation
lolleko
approved these changes
Aug 20, 2021
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
…#1095) * Fix context failed to be resolved due to parentheses * Added test with more parentheses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have introduced an additional TS transformer before we transform to lua. The transformer simply looks for any call expressions and when it finds them it will unwrap any (nested)
ParenthesisExpressions that might be in its expression field. This means that calls likets.isPropertyAssignment(callExpression.expression)will not suddenly befalsedue to a randomParenthesisExpression.For now I only transformed callexpression.expressions, in the future we could extend this to do other TS AST transformations before transforming to Lua.
Fixes #959