Merged
Conversation
# Conflicts: # src/LuaLib.ts # src/lualib/declarations/global.d.ts
tomblind
requested changes
Aug 18, 2021
Collaborator
tomblind
left a comment
tomblind
left a comment
There was a problem hiding this comment.
It would be good to have tests of throwing errors inside async functions as well as catching them with with try...catch blocks.
Also, while it should work fine, a good test would be awaiting inside of a statement that gets wrapped in an IIFE, like a complex conditional :?.
lolleko
requested changes
Aug 18, 2021
lolleko
approved these changes
Aug 18, 2021
tomblind
reviewed
Aug 20, 2021
…perfluous try/catch
tomblind
requested changes
Aug 20, 2021
Collaborator
tomblind
left a comment
tomblind
left a comment
There was a problem hiding this comment.
Was about to approve this when I realized something. This isn't going to play with varargs at all. Currently it will optimize and try to directly use the ellipses. But even if you disable vararg optimzation for async functions, the wrapping of the ellipsis will still occur inside the function expression, which will break. The wrapping of the ellipsis needs to get lifted out somehow.
async function foo(...args: unknown[]) {
console.log(...args);
}function foo(self, ...)
return __TS__AsyncAwaiter(
function()
local args = {...}
print(
table.unpack(args)
)
end
)
end
Co-authored-by: Tom <tomblind@users.noreply.github.com>
tomblind
approved these changes
Aug 20, 2021
|
I'm so excited to use this!!! Thank you |
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Initial lualib promise class implementation * First promise tests * More promise tests * Promise class implementation * Implemented Promise.all * Promise.any * Promise.race * Promise.allSettled * fix prettier * Add promise example usage test * Added missing lualib dependencies for PromiseConstructor functions * Immediately call then/catch/finally callbacks on promises that are already resolved * Transform all references to Promise to __TS__Promise * PR feedback * Removed incorrect asyncs * Add test for direct chaining * Add test for finally and correct wrong behavior it caught * Added test throwing in parallel and chained then onFulfilleds * Fixed pull request link in ArrayIsArray lualib comment * Initial async await * Disallow await in top-level scope * Add await rejection test * Give await the correct lualib dependencies * use coroutine.status instead of lastData * Better top level await check * Add tests for async lambdas and throws in async functions * Moved toplevel await check to transformAwaitExpression and removed superfluous try/catch * fix for vararg access in async functions (TypeScriptToLua#1096) Co-authored-by: Tom <tomblind@users.noreply.github.com> Co-authored-by: Tom <26638278+tomblind@users.noreply.github.com> Co-authored-by: Tom <tomblind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for async/await using generators/yields as explained in this article. The actual implementation is based on the TypeScript polyfill as included in the comments in the lualib source.
Generators and yield are implemented in tstl using coroutines, for now it is not possible to use await at the very top level of your code because that would be outside of coroutines, for now
awaitmust appear in anasyncfunction.