Fix noSelf in object literal methods#1088
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Aug 15, 2021
Merged
Conversation
This check is absent in the internal typescript method
Perryvw
reviewed
Aug 15, 2021
test/unit/objectLiteral.spec.ts
Outdated
| return [foo.method("a") ?? "nil", foo.func("b") ?? "nil", foo.arrow("c") ?? "nil"] | ||
| `.expectToMatchJsResult(); | ||
| // language=TypeScript | ||
| util.testFunction` |
Member
There was a problem hiding this comment.
Please split this into two separate tests
test/unit/objectLiteral.spec.ts
Outdated
| } | ||
| ); | ||
|
|
||
| test("noSelf in object literal functions", () => { |
Member
There was a problem hiding this comment.
I would also like to see a third test with the code from your issue:
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Fix noSelf in object literal methods * Add isObjectLiteralExpression check on parent This check is absent in the internal typescript method * Add more tests for PR Co-authored-by: Benjamin Ye <24237065+enjoydambience@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1081.
Found the internal method on
ts.TypeCheckerthat does what is needed.