Merged
Conversation
Typescript doesn't actually "spread out" jsx spread children, even though the syntax is supported.
GlassBricks
commented
Jul 29, 2021
lolleko
reviewed
Jul 29, 2021
Perryvw
reviewed
Jul 29, 2021
Perryvw
approved these changes
Jul 30, 2021
GlassBricks
added a commit
to GlassBricks/TypeScriptToLua
that referenced
this pull request
Sep 5, 2021
…ptToLua#1052)". This reverts commit 987899c.
GlassBricks
added a commit
to GlassBricks/TypeScriptToLua
that referenced
this pull request
Sep 5, 2021
…ptToLua#1052)". This reverts commit 987899c.
GlassBricks
added a commit
to GlassBricks/TypeScriptToLua
that referenced
this pull request
Sep 5, 2021
…ptToLua#1052)". This reverts commit 987899c.
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* JSX support * Add jsx and jsxFrag pragma support * Remove unneeded flattenSpreadExpressions call. Typescript doesn't actually "spread out" jsx spread children, even though the syntax is supported. * Changes for PR. * Add license for functions copied from sucrase * Remove jsx snapshot test Co-authored-by: Benjamin Ye <24237065+enjoydambience@users.noreply.github.com>
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Use `ts.transformJsx` instead for jsx. Reverts "JSX support (TypeScriptToLua#1052)". This reverts commit 987899c. * Add comment explaining overriding compiler options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides basic JSX support (#597).
jsx: "react"compiler option is supported.reactNamespacecompiler option is ignored; it is deprecated anyways (usejsxFactoryoption instead).JSX pragma comments is not (yet) supported. This could be implemented in the future using annotations.JSX pragma comments support added in second commit.
This implementation uses typescript's jsx transformation as reference and for tests. This means that this implementation is different from some exisiting jsx efforts for tstl in some areas:
createElementshould be accepted as a rest (...) parameter, not an array.These should probably be documented if released.
Some jsx text processing implementations were copied from sucrase, which is released under the MIT liscence.
Closes #597