Fix getEmitOutDir not using project root if no outDir is provided #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolleko
reviewed
Jun 20, 2021
test/transpile/paths.spec.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| describe("getEmitOutDir", () => { |
Member
There was a problem hiding this comment.
Redundant? Already tested via getEmitPath tests?
test/transpile/paths.spec.ts
Outdated
| const { transpiledFiles } = util.testModule`` | ||
| .setMainFileName("main.ts") | ||
| .addExtraFile("dir/extra.ts", "") | ||
| .setOptions({ outDir: path.join(cwd, "tstl-out") }) |
Member
There was a problem hiding this comment.
Maybe add a var for path.join(cwd, "tstl-out") that can be reused in the asserts below.
test/transpile/paths.spec.ts
Outdated
| const { transpiledFiles } = util.testModule`` | ||
| .setMainFileName("src/main.ts") | ||
| .addExtraFile("src/extra.ts", "") | ||
| .setOptions({ rootDir: "src", outDir: path.join(cwd, "tstl-out") }) |
Member
There was a problem hiding this comment.
See above code duplication path.join(cwd, "tstl-out")
lolleko
approved these changes
Jun 21, 2021
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
…peScriptToLua#1038) * Fix getEmitOutDir not using project root if no outDir is provided * Removed redundant tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036