Implement array.entries() #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomblind
reviewed
Jun 12, 2021
| return result; | ||
| }, | ||
| }; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why not just this?
function __TS__ArrayEntries<T>(this: void, array: T[]) {
return ipairs(array);
}
Member
Author
There was a problem hiding this comment.
Because TS defines the type of entries as returning IterableIterator<[number, T]>, and I don't think ipairs LuaIterable<LuaMultiReturn<[number, NonNullable<T>]>> is 1:1 assignable to that since it's a different iterator kind and also the lack of LuaMultiReturn.
Collaborator
There was a problem hiding this comment.
Ah yeah, that would be a problem if used indirectly. It's a shame since this version is so much more complex.
It might be good to add a test for indirect use:
...
const entries = array.entries();
for (const [i, v] of entries) {
...
Member
Author
There was a problem hiding this comment.
Good call, added a test for indirect use as well as destructuring, those both fail if ipairs is used
tomblind
approved these changes
Jun 12, 2021
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Implement array.entries * Added extra test for indirect use of array.entries() * Added destructuring test for array.entries * Fix prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1028