Replaced deprecated factory functions #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enabled some eslint rules & fixed violations
Perryvw
approved these changes
Mar 25, 2021
| Unpack = "Unpack", | ||
| } | ||
|
|
||
| /* eslint-disable @typescript-eslint/naming-convention */ |
Member
There was a problem hiding this comment.
Why is it complaining here, because of the key names?
Member
Author
There was a problem hiding this comment.
Yes PascalCase key names are not allowed. I didn't change them to camelCase because I wasn't sure what the implications of that would be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enabled some eslint rules & fixed violations