Fix transform string.indexOf with out plain parameter. (#679)

lightrabbit · Perryvw · commit f9f5fd7f784b · 2019-07-24T09:34:26.000+02:00
* Add edge test case.
That makes unit test for `string.indexOf` failure.

* Fix transform `string.indexOf` with out `plain` parameter.

* Fix make two expressions collapsed to a single call
diff --git a/src/LuaTransformer.ts b/src/LuaTransformer.ts
@@ -4350,17 +4350,14 @@ export class LuaTransformer {
             case "concat":
                 return this.transformLuaLibFunction(LuaLibFeature.StringConcat, node, caller, ...params);
             case "indexOf":
-                const stringExpression =
-                    node.arguments.length === 1
-                        ? this.createStringCall("find", node, caller, params[0])
-                        : this.createStringCall(
-                              "find",
-                              node,
-                              caller,
-                              params[0],
-                              this.expressionPlusOne(params[1]),
-                              tstl.createBooleanLiteral(true)
-                          );
+                const stringExpression = this.createStringCall(
+                    "find",
+                    node,
+                    caller,
+                    params[0],
+                    params[1] ? this.expressionPlusOne(params[1]) : tstl.createNilLiteral(),
+                    tstl.createBooleanLiteral(true)
+                );
 
                 return tstl.createParenthesizedExpression(
                     tstl.createBinaryExpression(
diff --git a/test/unit/string.spec.ts b/test/unit/string.spec.ts
@@ -132,6 +132,7 @@ test.each([
     { inp: "hello test", searchValue: "t" },
     { inp: "hello test", searchValue: "h" },
     { inp: "hello test", searchValue: "invalid" },
+    { inp: "hello.test", searchValue: "." },
 ])("string.indexOf (%p)", ({ inp, searchValue }) => {
     const result = util.transpileAndExecute(`return "${inp}".indexOf("${searchValue}")`);
 
