Factorize transpilation diagnostics

ark120202 · ark120202 · commit e23b1d62ec9d · 2020-03-09T14:45:03.000Z
diff --git a/src/transformation/utils/diagnostics.ts b/src/transformation/utils/diagnostics.ts
@@ -97,10 +97,6 @@ export const luaIteratorForbiddenUsage = createDiagnosticFactory(
         "the '@tupleReturn' annotation."
 );
 
-export const unsupportedSyntaxKind = createDiagnosticFactory(
-    (description: string, kind: ts.SyntaxKind) => `Unsupported ${description} kind: ${ts.SyntaxKind[kind]}`
-);
-
 export const unsupportedNullishCoalescing = createDiagnosticFactory("Nullish coalescing is not supported.");
 
 export const unsupportedAccessorInObjectLiteral = createDiagnosticFactory(
diff --git a/src/transpilation/diagnostics.ts b/src/transpilation/diagnostics.ts
@@ -1,51 +1,35 @@
 import * as ts from "typescript";
 
-export const toLoadTransformerItShouldBeTranspiled = (transform: string): ts.Diagnostic => ({
+const createDiagnosticFactory = <TArgs extends any[]>(getMessage: (...args: TArgs) => string) => (
+    ...args: TArgs
+): ts.Diagnostic => ({
     file: undefined,
     start: undefined,
     length: undefined,
     category: ts.DiagnosticCategory.Error,
     code: 0,
     source: "typescript-to-lua",
-    messageText: `To load "${transform}" transformer it should be transpiled or "ts-node" should be installed`,
+    messageText: getMessage(...args),
 });
 
-export const couldNotResolveTransformerFrom = (transform: string, base: string): ts.Diagnostic => ({
-    file: undefined,
-    start: undefined,
-    length: undefined,
-    category: ts.DiagnosticCategory.Error,
-    code: 0,
-    source: "typescript-to-lua",
-    messageText: `Could not resolve "${transform}" transformer from "${base}".`,
-});
+export const toLoadTransformerItShouldBeTranspiled = createDiagnosticFactory(
+    (transform: string) =>
+        `To load "${transform}" transformer it should be transpiled or "ts-node" should be installed.`
+);
 
-export const transformerShouldHaveAExport = (transform: string, importName: string): ts.Diagnostic => ({
-    file: undefined,
-    start: undefined,
-    length: undefined,
-    category: ts.DiagnosticCategory.Error,
-    code: 0,
-    source: "typescript-to-lua",
-    messageText: `"${transform}" transformer should have a "${importName}" export`,
-});
+export const couldNotResolveTransformerFrom = createDiagnosticFactory(
+    (transform: string, base: string) => `Could not resolve "${transform}" transformer from "${base}".`
+);
 
-export const transformerShouldBeATsTransformerFactory = (transform: string): ts.Diagnostic => ({
-    file: undefined,
-    start: undefined,
-    length: undefined,
-    category: ts.DiagnosticCategory.Error,
-    code: 0,
-    source: "typescript-to-lua",
-    messageText: `"${transform}" transformer should be a ts.TransformerFactory or an object with ts.TransformerFactory values`,
-});
+export const transformerShouldHaveAExport = createDiagnosticFactory(
+    (transform: string, importName: string) => `"${transform}" transformer should have a "${importName}" export.`
+);
 
-export const couldNotFindBundleEntryPoint = (entryPoint: string): ts.Diagnostic => ({
-    file: undefined,
-    start: undefined,
-    length: undefined,
-    category: ts.DiagnosticCategory.Error,
-    code: 0,
-    source: "typescript-to-lua",
-    messageText: `Could not find bundle entry point '${entryPoint}'. It should be a file in the project.`,
-});
+export const transformerShouldBeATsTransformerFactory = createDiagnosticFactory(
+    (transform: string) =>
+        `"${transform}" transformer should be a ts.TransformerFactory or an object with ts.TransformerFactory values.`
+);
+
+export const couldNotFindBundleEntryPoint = createDiagnosticFactory(
+    (entryPoint: string) => `Could not find bundle entry point '${entryPoint}'. It should be a file in the project.`
+);
