fixed commenting of inline sourcemaps (#519)

tomblind · Perryvw · commit dd7e5de7ea7f · 2019-04-12T13:41:58.000+02:00
* fixed commenting of inline sourcemaps and added test

* forgot to run prettier
diff --git a/src/LuaPrinter.ts b/src/LuaPrinter.ts
@@ -83,7 +83,7 @@ export class LuaPrinter {
         const map = sourceMap.toString();
         const base64Map = Buffer.from(map).toString('base64');
 
-        return `//# sourceMappingURL=data:application/json;base64,${base64Map}\n`;
+        return `--# sourceMappingURL=data:application/json;base64,${base64Map}\n`;
     }
 
     private printStackTraceOverride(rootNode: SourceNode): string {
diff --git a/test/unit/sourcemaps.spec.ts b/test/unit/sourcemaps.spec.ts
@@ -1,5 +1,5 @@
 import * as util from "../util";
-import { LuaLibImportKind } from "../../src/CompilerOptions";
+import { LuaLibImportKind, CompilerOptions } from "../../src/CompilerOptions";
 import { SourceMapConsumer, Position } from "source-map";
 
 test.each([
@@ -109,6 +109,33 @@ test("sourceMapTraceback saves sourcemap in _G", () => {
     }
 });
 
+test("Inline sourcemaps", () => {
+    const typeScriptSource = `
+        function abc() {
+            return def();
+        }
+        function def() {
+            return "foo";
+        }
+        return abc();`;
+
+    const compilerOptions: CompilerOptions = {
+        inlineSourceMap: true,
+    };
+
+    const { lua, sourceMap } = util.transpileStringResult(typeScriptSource, compilerOptions);
+
+    const inlineSourceMapMatch = lua.match(
+        /--# sourceMappingURL=data:application\/json;base64,([A-Za-z0-9+/=]+)/,
+    );
+    expect(inlineSourceMapMatch !== null && inlineSourceMapMatch !== undefined).toBe(true);
+
+    const inlineSourceMap = Buffer.from(inlineSourceMapMatch[1], "base64").toString();
+    expect(sourceMap).toBe(inlineSourceMap);
+
+    expect(util.executeLua(lua)).toBe("foo");
+});
+
 // Helper functions
 
 function lineAndColumnOf(text: string, pattern: string): Position {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ export class LuaPrinter {`
`83`	`83`	`const map = sourceMap.toString();`
`84`	`84`	`const base64Map = Buffer.from(map).toString('base64');`
`85`	`85`
`86`		- return `//# sourceMappingURL=data:application/json;base64,${base64Map}\n`;
	`86`	+ return `--# sourceMappingURL=data:application/json;base64,${base64Map}\n`;
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`private printStackTraceOverride(rootNode: SourceNode): string {`