Fix missing stringaccess lualib dependency (#1015)

Perryvw · web-flow · commit d86ef928d996 · 2021-04-28T08:52:36.000+02:00
diff --git a/src/LuaLib.ts b/src/LuaLib.ts
@@ -106,7 +106,7 @@ const luaLibDependencies: Partial<Record<LuaLibFeature, LuaLibFeature[]>> = {
     WeakMap: [LuaLibFeature.InstanceOf, LuaLibFeature.Iterator, LuaLibFeature.Symbol, LuaLibFeature.Class],
     WeakSet: [LuaLibFeature.InstanceOf, LuaLibFeature.Iterator, LuaLibFeature.Symbol, LuaLibFeature.Class],
     Spread: [LuaLibFeature.Iterator, LuaLibFeature.Unpack],
-    StringSplit: [LuaLibFeature.StringSubstring],
+    StringSplit: [LuaLibFeature.StringSubstring, LuaLibFeature.StringAccess],
     SymbolRegistry: [LuaLibFeature.Symbol],
 };
 /* eslint-enable @typescript-eslint/naming-convention */
diff --git a/test/unit/builtins/string.spec.ts b/test/unit/builtins/string.spec.ts
@@ -200,6 +200,13 @@ test("string.split inline", () => {
         .expectToMatchJsResult();
 });
 
+// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1009
+test("string.split inline empty separator", () => {
+    util.testExpression`"a, b, c".split("")`
+        .setOptions({ luaLibImport: LuaLibImportKind.Inline })
+        .expectToMatchJsResult();
+});
+
 test.each([
     { inp: "hello test", index: 0 },
     { inp: "hello test", index: 1 },
