Fix #1295 (#1296)

GlassBricks · web-flow · commit d2accd722194 · 2022-06-24T17:24:46.000+02:00
diff --git a/src/transformation/utils/function-context.ts b/src/transformation/utils/function-context.ts
@@ -79,8 +79,15 @@ export function getDeclarationContextType(
 
     // When using --noImplicitSelf and the signature is defined in a file targeted by the program apply the @noSelf rule.
     const options = program.getCompilerOptions() as CompilerOptions;
-    if (options.noImplicitSelf && program.getSourceFile(signatureDeclaration.getSourceFile().fileName) !== undefined) {
-        return ContextType.Void;
+    if (options.noImplicitSelf) {
+        const sourceFile = program.getSourceFile(signatureDeclaration.getSourceFile().fileName);
+        if (
+            sourceFile !== undefined &&
+            !program.isSourceFileDefaultLibrary(sourceFile) &&
+            !program.isSourceFileFromExternalLibrary(sourceFile)
+        ) {
+            return ContextType.Void;
+        }
     }
 
     // Walk up to find @noSelf or @noSelfInFile
diff --git a/test/unit/functions/noImplicitSelfOption.spec.ts b/test/unit/functions/noImplicitSelfOption.spec.ts
@@ -35,6 +35,18 @@ test.each(["\\", "/"])("transpileFiles handles paths with noImplicitSelf and %s
     }
 });
 
+test("noImplicitSelf does not affect functions in default libraries", () => {
+    util.testFunction`
+        const array = [1, 2, 3];
+        const items = array.filter(x => x > 1); // array.filter is in external library
+        return items;
+    `
+        .setOptions({
+            noImplicitSelf: true,
+        })
+        .expectToMatchJsResult();
+});
+
 test("enables noSelfInFile behavior for methods", () => {
     util.testFunction`
         class FooBar {
