Fix lua identifier (#358)

TheLartians · Perryvw · commit d22da21db509 · 2019-01-26T13:48:47.000+01:00
* fix-lua-identifier

* added test
diff --git a/src/TSHelper.ts b/src/TSHelper.ts
@@ -514,7 +514,8 @@ export class TSHelper {
     }
 
     public static isValidLuaIdentifier(str: string): boolean {
-        return str.match(/[a-zA-Z_][a-zA-Z0-9_]*/) !== null;
+        const match = str.match(/[a-zA-Z_][a-zA-Z0-9_]*/);
+        return match && match[0] === str;
     }
 
     public static isFalsible(type: ts.Type, strictNullChecks: boolean): boolean {
diff --git a/test/unit/assignments.spec.ts b/test/unit/assignments.spec.ts
@@ -803,4 +803,14 @@ export class AssignmentTests {
             "Unsupported assignment of mixed function/method overload. "
             + "Overloads should either be all functions or all methods, but not both.");
     }
+
+    @Test("String table access")
+    public stringTableAccess(assignType: string): void {
+        const code = `const dict : {[key:string]:any} = {};
+                      dict["a b"] = 3;
+                      return dict["a b"];`;
+        const result = util.transpileAndExecute(code);
+        Expect(result).toBe(3);
+    }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,8 @@ export class TSHelper {`
`514`	`514`	`}`
`515`	`515`
`516`	`516`	`public static isValidLuaIdentifier(str: string): boolean {`
`517`		`- return str.match(/[a-zA-Z_][a-zA-Z0-9_]*/) !== null;`
	`517`	`+ const match = str.match(/[a-zA-Z_][a-zA-Z0-9_]*/);`
	`518`	`+ return match && match[0] === str;`
`518`	`519`	`}`
`519`	`520`
`520`	`521`	`public static isFalsible(type: ts.Type, strictNullChecks: boolean): boolean {`