Stop prefixing identifiers from global augs (#804)

hazzard993 · Perryvw · commit c920bb3533d1 · 2020-01-19T15:48:11.000+01:00
* Stop prefixing identifiers from global augs

* Check for GlobalAug inside getSymbolExportScope
diff --git a/src/transformation/utils/export.ts b/src/transformation/utils/export.ts
@@ -47,6 +47,10 @@ export function getIdentifierExportScope(
     return getSymbolExportScope(context, symbol);
 }
 
+function isGlobalAugmentation(module: ts.ModuleDeclaration): boolean {
+    return (module.flags & ts.NodeFlags.GlobalAugmentation) !== 0;
+}
+
 export function getSymbolExportScope(
     context: TransformationContext,
     symbol: ts.Symbol
@@ -64,6 +68,10 @@ export function getSymbolExportScope(
         return undefined;
     }
 
+    if (ts.isModuleDeclaration(scope) && isGlobalAugmentation(scope)) {
+        return undefined;
+    }
+
     if (!isSymbolExportedFromScope(context, symbol, scope)) {
         return undefined;
     }
diff --git a/test/translation/__snapshots__/transformation.spec.ts.snap b/test/translation/__snapshots__/transformation.spec.ts.snap
@@ -82,6 +82,11 @@ end
 return ____exports"
 `;
 
+exports[`Transformation (globalAugmentation) 1`] = `
+"local ____exports = globalVariable
+return ____exports"
+`;
+
 exports[`Transformation (methodRestArguments) 1`] = `
 "require(\\"lualib_bundle\\");
 MyClass = __TS__Class()
diff --git a/test/translation/transformation/globalAugmentation.ts b/test/translation/transformation/globalAugmentation.ts
@@ -0,0 +1,5 @@
+declare global {
+    export const globalVariable: number;
+}
+
+export = globalVariable;

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,10 @@ export function getIdentifierExportScope(`
`47`	`47`	`return getSymbolExportScope(context, symbol);`
`48`	`48`	`}`
`49`	`49`
	`50`	`+function isGlobalAugmentation(module: ts.ModuleDeclaration): boolean {`
	`51`	`+ return (module.flags & ts.NodeFlags.GlobalAugmentation) !== 0;`
	`52`	`+}`
	`53`	`+`
`50`	`54`	`export function getSymbolExportScope(`
`51`	`55`	`context: TransformationContext,`
`52`	`56`	`symbol: ts.Symbol`
`@@ -64,6 +68,10 @@ export function getSymbolExportScope(`
`64`	`68`	`return undefined;`
`65`	`69`	`}`
`66`	`70`
	`71`	`+ if (ts.isModuleDeclaration(scope) && isGlobalAugmentation(scope)) {`
	`72`	`+ return undefined;`
	`73`	`+ }`
	`74`	`+`
`67`	`75`	`if (!isSymbolExportedFromScope(context, symbol, scope)) {`
`68`	`76`	`return undefined;`
`69`	`77`	`}`