preserve test intent: use strictNullChecks: false instead of casts

RealColdFry · RealColdFry · commit c72aaedca34b · 2026-03-30T00:55:32.000+01:00
diff --git a/test/unit/error.spec.ts b/test/unit/error.spec.ts
@@ -82,16 +82,15 @@ test("return nil from try", () => {
 
 test("multi return from try", () => {
     const testBuilder = util.testFunction`
-        function foobar(): LuaMultiReturn<[string, string]> {
+        function foobar() {
             try {
                 return $multi("foo", "bar");
             } catch {
             }
-            return $multi("", "");
         }
         const [foo, bar] = foobar();
         return foo + bar;
-    `.withLanguageExtensions();
+    `.setOptions({ strictNullChecks: false }).withLanguageExtensions();
     expect(testBuilder.getMainLuaCodeChunk()).not.toMatch("unpack(foobar");
     testBuilder.expectToMatchJsResult();
 });
diff --git a/test/unit/language-extensions/multi.spec.ts b/test/unit/language-extensions/multi.spec.ts
@@ -35,12 +35,13 @@ test("Destructuring assignment of LuaMultiReturn", () => {
 test("Destructuring assignment of LuaMultiReturn returning nil", () => {
     util.testModule`
         function multiReturn(): LuaMultiReturn<[number, number, number]> {
-            return undefined as any;
+            return;
         }
 
         const [a, ...b] = multiReturn();
         export {a, b};
     `
+        .setOptions({ strictNullChecks: false })
         .withLanguageExtensions()
         .expectToEqual({ a: undefined, b: [] });
 });
@@ -272,9 +273,10 @@ test("return $multi from try", () => {
             } catch {
             }
         }
-        const [_, a] = multiTest()!;
+        const [_, a] = multiTest();
         return a;
     `
+        .setOptions({ strictNullChecks: false })
         .withLanguageExtensions()
         .expectToEqual(2);
 });
@@ -304,9 +306,10 @@ test("return LuaMultiReturn from try", () => {
             } catch {
             }
         }
-        const [_, a] = multiTest()!;
+        const [_, a] = multiTest();
         return a;
     `
+        .setOptions({ strictNullChecks: false })
         .withLanguageExtensions()
         .expectToEqual(2);
 });
diff --git a/test/unit/switch.spec.ts b/test/unit/switch.spec.ts
@@ -138,11 +138,10 @@ test("switch using variable re-declared in cases", () => {
         switch (foo) {
             case 0:
                 let foo = true;
-                return foo;
             case 1:
-                return false;
+                return foo;
         }
-    `.expectToMatchJsResult();
+    `.setOptions({ strictNullChecks: false }).expectToMatchJsResult();
 });
 
 test.each([0, 1, 2])("switch with block statement scope (%p)", inp => {

Original file line number	Diff line number	Diff line change
`@@ -35,12 +35,13 @@ test("Destructuring assignment of LuaMultiReturn", () => {`
`35`	`35`	`test("Destructuring assignment of LuaMultiReturn returning nil", () => {`
`36`	`36`	util.testModule`
`37`	`37`	`function multiReturn(): LuaMultiReturn<[number, number, number]> {`
`38`		`- return undefined as any;`
	`38`	`+ return;`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`const [a, ...b] = multiReturn();`
`42`	`42`	`export {a, b};`
`43`	`43`	`
	`44`	`+ .setOptions({ strictNullChecks: false })`
`44`	`45`	`.withLanguageExtensions()`
`45`	`46`	`.expectToEqual({ a: undefined, b: [] });`
`46`	`47`	`});`
`@@ -272,9 +273,10 @@ test("return $multi from try", () => {`
`272`	`273`	`} catch {`
`273`	`274`	`}`
`274`	`275`	`}`
`275`		`- const [_, a] = multiTest()!;`
	`276`	`+ const [_, a] = multiTest();`
`276`	`277`	`return a;`
`277`	`278`	`
	`279`	`+ .setOptions({ strictNullChecks: false })`
`278`	`280`	`.withLanguageExtensions()`
`279`	`281`	`.expectToEqual(2);`
`280`	`282`	`});`
`@@ -304,9 +306,10 @@ test("return LuaMultiReturn from try", () => {`
`304`	`306`	`} catch {`
`305`	`307`	`}`
`306`	`308`	`}`
`307`		`- const [_, a] = multiTest()!;`
	`309`	`+ const [_, a] = multiTest();`
`308`	`310`	`return a;`
`309`	`311`	`
	`312`	`+ .setOptions({ strictNullChecks: false })`
`310`	`313`	`.withLanguageExtensions()`
`311`	`314`	`.expectToEqual(2);`
`312`	`315`	`});`