Temporary loosen for...of initializer variable declaration check

ark120202 · ark120202 · commit c511364c11cd · 2019-12-12T19:45:49.000Z
diff --git a/src/transformation/visitors/loops/for-of.ts b/src/transformation/visitors/loops/for-of.ts
@@ -35,11 +35,18 @@ function transformForOfInitializer(
             return;
         }
 
-        // we can safely assume that for vars are not exported and therefore VariableDeclarationStatement's
-        const assignmentStatement = cast(
-            transformVariableDeclaration(context, initializer.declarations[0])[0],
-            lua.isVariableDeclarationStatement
-        );
+        // TODO: It's not correct without https://github.com/TypeScriptToLua/TypeScriptToLua/pull/762
+        // // we can safely assume that for vars are not exported and therefore VariableDeclarationStatement's
+        // const assignmentStatement = cast(
+        //     transformVariableDeclaration(context, initializer.declarations[0])[0],
+        //     lua.isVariableDeclarationStatement
+        // );
+
+        const assignmentStatement = transformVariableDeclaration(
+            context,
+            initializer.declarations[0]
+        )[0] as lua.VariableDeclarationStatement | undefined;
+        assert(assignmentStatement);
 
         return lua.createVariableDeclarationStatement(assignmentStatement.left, expression);
     } else {
diff --git a/test/unit/builtins/map.spec.ts b/test/unit/builtins/map.spec.ts
@@ -160,14 +160,14 @@ describe.each(iterationMethods)("map.%s() preserves insertion order", iterationM
     test("basic", () => {
         util.testFunction`
             const mymap = new Map();
-                
+
             mymap.set("x", 1);
             mymap.set("a", 2);
             mymap.set(4, 3);
             mymap.set("b", 6);
             mymap.set(1, 4);
             mymap.set("a", 5);
-            
+
             mymap.delete("b");
 
             return [...mymap.${iterationMethod}()];
@@ -177,11 +177,11 @@ describe.each(iterationMethods)("map.%s() preserves insertion order", iterationM
     test("after removing last", () => {
         util.testFunction`
             const mymap = new Map();
-                
+
             mymap.set("x", 1);
             mymap.set("a", 2);
             mymap.set(4, 3);
-            
+
             mymap.delete(4);
 
             return [...mymap.${iterationMethod}()];
@@ -191,11 +191,11 @@ describe.each(iterationMethods)("map.%s() preserves insertion order", iterationM
     test("after removing first", () => {
         util.testFunction`
             const mymap = new Map();
-                
+
             mymap.set("x", 1);
             mymap.set("a", 2);
             mymap.set(4, 3);
-            
+
             mymap.delete("x");
 
             return [...mymap.${iterationMethod}()];
@@ -205,10 +205,10 @@ describe.each(iterationMethods)("map.%s() preserves insertion order", iterationM
     test("after removing all", () => {
         util.testFunction`
             const mymap = new Map();
-                
+
             mymap.set("x", 1);
             mymap.set("a", 2);
-            
+
             mymap.delete("a");
             mymap.delete("x");
 
