Incremental compilation in watch mode (#488)

TheLartians · Perryvw · commit c4a387a928d1 · 2019-03-21T23:32:14.000+01:00
* emit only affected files

* track transpiler errors

* return 0 for success

* return 0 for declarations

* do a full recompile after transpiler error

* forgot about lazy evaluation

* test if affected file is a SourceFile
diff --git a/src/Compiler.ts b/src/Compiler.ts
@@ -43,10 +43,34 @@ export function watchWithOptions(fileNames: string[], options: CompilerOptions):
         host = ts.createWatchCompilerHost(fileNames, options, ts.sys, ts.createSemanticDiagnosticsBuilderProgram);
     }
 
+    let fullRecompile = true;
     host.afterProgramCreate = program => {
         const transpiler = new LuaTranspiler(program.getProgram());
+        let status = transpiler.reportErrors();
+
+        if (status === 0) {
+            if (fullRecompile) {
+                status = transpiler.emitFilesAndReportErrors();
+            } else {
+                while (true) {
+                    const currentFile = program.getSemanticDiagnosticsOfNextAffectedFile();
+                    if (!currentFile) { break; }
+
+                    if ("fileName" in currentFile.affected) { // test if currentFile.affected is `ts.SourceFile`
+                      const fileStatus = transpiler.emitSourceFile(currentFile.affected);
+                      status |= fileStatus;
+                    } else {
+                        for (const sourceFile of currentFile.affected.getSourceFiles()) {
+                            const fileStatus = transpiler.emitSourceFile(sourceFile);
+                            status |= fileStatus;
+                        }
+                    }
+                }
+            }
+            // do a full recompile after transpiler error.
+            fullRecompile = status !== 0;
+        }
 
-        const status = transpiler.emitFilesAndReportErrors();
         const errorDiagnostic: ts.Diagnostic = {
             category: undefined,
             code: 6194,
diff --git a/src/LuaTranspiler.ts b/src/LuaTranspiler.ts
@@ -38,7 +38,7 @@ export class LuaTranspiler {
         return options;
     }
 
-    private reportErrors(): number {
+    public reportErrors(): number {
         // Get all diagnostics, ignore unsupported extension
         const diagnostics = ts.getPreEmitDiagnostics(this.program).filter(diag => diag.code !== 6054);
         diagnostics.forEach(diag => this.reportDiagnostic(diag));
@@ -65,13 +65,15 @@ export class LuaTranspiler {
     }
 
     public emitFilesAndReportErrors(): number {
-        const error = this.reportErrors();
-        if (error > 0) {
-            return error;
+        let status = this.reportErrors();
+
+        if (status > 0) {
+            return status;
         }
 
         this.program.getSourceFiles().forEach(sourceFile => {
-            this.emitSourceFile(sourceFile);
+            const sourceStatus = this.emitSourceFile(sourceFile);
+            status |= sourceStatus;
         });
 
         // Copy lualib to target dir
@@ -81,10 +83,10 @@ export class LuaTranspiler {
             this.emitLuaLib();
         }
 
-        return 0;
+        return status;
     }
 
-    public emitSourceFile(sourceFile: ts.SourceFile): void {
+    public emitSourceFile(sourceFile: ts.SourceFile): number {
         if (!sourceFile.isDeclarationFile) {
             try {
                 const rootDir = this.options.rootDir;
@@ -119,11 +121,13 @@ export class LuaTranspiler {
                     // Graciously handle transpilation errors
                     console.error("Encountered error parsing file: " + exception.message);
                     console.error(`${sourceFile.fileName} (${1 + pos.line},${pos.character})\n${exception.stack}`);
+                    return 1;
                 } else {
                     throw exception;
                 }
             }
         }
+        return 0;
     }
 
     public transpileSourceFile(sourceFile: ts.SourceFile): string {

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ export class LuaTranspiler {`
`38`	`38`	`return options;`
`39`	`39`	`}`
`40`	`40`
`41`		`- private reportErrors(): number {`
	`41`	`+ public reportErrors(): number {`
`42`	`42`	`// Get all diagnostics, ignore unsupported extension`
`43`	`43`	`const diagnostics = ts.getPreEmitDiagnostics(this.program).filter(diag => diag.code !== 6054);`
`44`	`44`	`diagnostics.forEach(diag => this.reportDiagnostic(diag));`
`@@ -65,13 +65,15 @@ export class LuaTranspiler {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`public emitFilesAndReportErrors(): number {`
`68`		`- const error = this.reportErrors();`
`69`		`- if (error > 0) {`
`70`		`- return error;`
	`68`	`+ let status = this.reportErrors();`
	`69`	`+`
	`70`	`+ if (status > 0) {`
	`71`	`+ return status;`
`71`	`72`	`}`
`72`	`73`
`73`	`74`	`this.program.getSourceFiles().forEach(sourceFile => {`
`74`		`- this.emitSourceFile(sourceFile);`
	`75`	`+ const sourceStatus = this.emitSourceFile(sourceFile);`
	`76`	`+ status \|= sourceStatus;`
`75`	`77`	`});`
`76`	`78`
`77`	`79`	`// Copy lualib to target dir`
`@@ -81,10 +83,10 @@ export class LuaTranspiler {`
`81`	`83`	`this.emitLuaLib();`
`82`	`84`	`}`
`83`	`85`
`84`		`- return 0;`
	`86`	`+ return status;`
`85`	`87`	`}`
`86`	`88`
`87`		`- public emitSourceFile(sourceFile: ts.SourceFile): void {`
	`89`	`+ public emitSourceFile(sourceFile: ts.SourceFile): number {`
`88`	`90`	`if (!sourceFile.isDeclarationFile) {`
`89`	`91`	`try {`
`90`	`92`	`const rootDir = this.options.rootDir;`
`@@ -119,11 +121,13 @@ export class LuaTranspiler {`
`119`	`121`	`// Graciously handle transpilation errors`
`120`	`122`	`console.error("Encountered error parsing file: " + exception.message);`
`121`	`123`	console.error(`${sourceFile.fileName} (${1 + pos.line},${pos.character})\n${exception.stack}`);
	`124`	`+ return 1;`
`122`	`125`	`} else {`
`123`	`126`	`throw exception;`
`124`	`127`	`}`
`125`	`128`	`}`
`126`	`129`	`}`
	`130`	`+ return 0;`
`127`	`131`	`}`
`128`	`132`
`129`	`133`	`public transpileSourceFile(sourceFile: ts.SourceFile): string {`