Fixed a bug where sometimes call expressions would get an incorrect context parameter (#1282)

Perryvw · web-flow · commit c47d3b3525cf · 2022-06-12T12:00:28.000+02:00
diff --git a/src/transformation/visitors/call.ts b/src/transformation/visitors/call.ts
@@ -288,7 +288,8 @@ export const transformCallExpression: FunctionVisitor<ts.CallExpression> = (node
             calledExpression,
             node.arguments,
             signature,
-            callContext
+            // Only pass context if noImplicitSelf is not configured
+            context.options.noImplicitSelf ? undefined : callContext
         );
     }
 
diff --git a/test/unit/jsx.spec.ts b/test/unit/jsx.spec.ts
@@ -288,6 +288,18 @@ describe("jsx", () => {
             .addExtraFile("myJsx.ts", customJsxLib)
             .expectToMatchJsResult();
     });
+    test("custom JSX factory with noImplicitSelf", () => {
+        testJsx`
+            return <a><b>c</b></a>
+        `
+            .setTsHeader(
+                `function createElement(tag: string | Function, props: { [key: string]: string | boolean }, ...children: any[]) {
+                return { tag, children };
+            }`
+            )
+            .setOptions({ jsxFactory: "createElement", noImplicitSelf: true })
+            .expectToMatchJsResult();
+    });
     test("custom fragment factory", () => {
         testJsx`
             return <><b>c</b></>

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,8 @@ export const transformCallExpression: FunctionVisitor<ts.CallExpression> = (node`
`288`	`288`	`calledExpression,`
`289`	`289`	`node.arguments,`
`290`	`290`	`signature,`
`291`		`- callContext`
	`291`	`+ // Only pass context if noImplicitSelf is not configured`
	`292`	`+ context.options.noImplicitSelf ? undefined : callContext`
`292`	`293`	`);`
`293`	`294`	`}`
`294`	`295`