simplify Promise.finally test to use expectToMatchJsResult

RealColdFry · RealColdFry · commit bbb3ab3c738e · 2026-03-27T10:28:06.000Z
Remove redundant tests that relied on synchronous polyfill behavior
differing from JS. Keep only the identity check which matches JS.
diff --git a/test/unit/builtins/promise.spec.ts b/test/unit/builtins/promise.spec.ts
@@ -1325,40 +1325,10 @@ describe("Promise.race", () => {
 });
 
 // https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1659
-describe("Promise.finally returns new promise", () => {
-    test("finally returns a different promise instance", () => {
-        util.testFunction`
-            const p1 = new Promise(() => {});
-            const p2 = p1.finally();
-            return p1 === p2;
-        `.expectToEqual(false);
-    });
-
-    test("finally preserves fulfillment value", () => {
-        util.testFunction`
-            let result: any;
-            Promise.resolve(42).finally(() => {}).then(v => { result = v; });
-            return result;
-        `.expectToEqual(42);
-    });
-
-    test("finally preserves rejection reason", () => {
-        util.testFunction`
-            let result: any;
-            Promise.reject("error").finally(() => {}).catch(r => { result = r; });
-            return result;
-        `.expectToEqual("error");
-    });
-
-    test("finally on deferred rejection preserves reason", () => {
-        util.testFunction`
-            const { promise, reject } = defer<string>();
-            let result: any;
-            promise.finally(() => {}).catch(r => { result = r; });
-            reject("deferred error");
-            return result;
-        `
-            .setTsHeader(promiseTestLib)
-            .expectToEqual("deferred error");
-    });
+test("finally returns a different promise instance", () => {
+    util.testFunction`
+        const p1 = new Promise(() => {});
+        const p2 = p1.finally();
+        return p1 === p2;
+    `.expectToMatchJsResult();
 });
