IndexOf and Splice (both broken)

lolleko · lolleko · commit b40178a9d573 · 2018-07-20T09:29:16.000+02:00
diff --git a/src/lualib/ArrayIndexOf.ts b/src/lualib/ArrayIndexOf.ts
@@ -0,0 +1,33 @@
+function __TS__ArrayIndexOf<T>(arr: T[], searchElement: T, fromIndex?: number) {
+    const len = arr.length;
+    if (len === 0) {
+        return -1;
+    }
+
+    let n = 0;
+    if (fromIndex) {
+        n = fromIndex;
+    }
+
+    if (n >= len) {
+        return -1;
+    }
+
+    let k;
+    if (n >= 0) {
+        k = 0;
+    } else {
+        k = len + n;
+        if (k < 0) {
+            k = 0;
+        }
+    }
+
+    for (let i = k; i < len; i++) {
+        if (arr[i] === searchElement) {
+            return i;
+        }
+    }
+
+    return -1;
+}
diff --git a/src/lualib/ArraySplice.ts b/src/lualib/ArraySplice.ts
@@ -57,7 +57,7 @@ function __TS__ArraySplice<T>(list: T[], start: number, deleteCount: number, ...
         }
         // c. d.
         for (let k = len; k > len - actualDeleteCount + itemCount; k--) {
-            list[k] = undefined;
+            list[k - 1] = undefined;
         }
     // 16.
     } else if (itemCount > actualDeleteCount) {
@@ -77,13 +77,14 @@ function __TS__ArraySplice<T>(list: T[], start: number, deleteCount: number, ...
 
     // 17.
     // 18.
-    for (let k = actualStart; k < items.length; k++) {
-        const e = items[k];
-        list[k] = e;
+    let j = actualStart;
+    for (const e of items) {
+        list[j] = e;
+        j++;
     }
 
     // 19.
-    for (let k = list.length; k > len - actualDeleteCount + itemCount; k--) {
+    for (let k = list.length - 1; k > len - actualDeleteCount + itemCount; k--) {
         list[k] = undefined;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ function __TS__ArraySplice<T>(list: T[], start: number, deleteCount: number, ...`
`57`	`57`	`}`
`58`	`58`	`// c. d.`
`59`	`59`	`for (let k = len; k > len - actualDeleteCount + itemCount; k--) {`
`60`		`- list[k] = undefined;`
	`60`	`+ list[k - 1] = undefined;`
`61`	`61`	`}`
`62`	`62`	`// 16.`
`63`	`63`	`} else if (itemCount > actualDeleteCount) {`
`@@ -77,13 +77,14 @@ function __TS__ArraySplice<T>(list: T[], start: number, deleteCount: number, ...`
`77`	`77`
`78`	`78`	`// 17.`
`79`	`79`	`// 18.`
`80`		`- for (let k = actualStart; k < items.length; k++) {`
`81`		`- const e = items[k];`
`82`		`- list[k] = e;`
	`80`	`+ let j = actualStart;`
	`81`	`+ for (const e of items) {`
	`82`	`+ list[j] = e;`
	`83`	`+ j++;`
`83`	`84`	`}`
`84`	`85`
`85`	`86`	`// 19.`
`86`		`- for (let k = list.length; k > len - actualDeleteCount + itemCount; k--) {`
	`87`	`+ for (let k = list.length - 1; k > len - actualDeleteCount + itemCount; k--) {`
`87`	`88`	`list[k] = undefined;`
`88`	`89`	`}`
`89`	`90`