Add test for plugin

Perryvw · Perryvw · commit ab6099c73340 · 2023-11-19T16:01:47.000+01:00
diff --git a/src/transpilation/plugins.ts b/src/transpilation/plugins.ts
@@ -56,6 +56,10 @@ export interface Plugin {
         result: EmitFile[]
     ) => ts.Diagnostic[] | void;
 
+    /**
+     * This function is called when trying to resolve the .lua file corresponding to a Lua require statement. Allows you to provide
+     * your own module resolution logic. If return value is undefined, regular module resolution is done.
+     */
     moduleResolution?: (
         moduleIdentifier: string,
         requiringFile: string,
diff --git a/src/transpilation/transpiler.ts b/src/transpilation/transpiler.ts
@@ -92,8 +92,8 @@ export class Transpiler {
 
         for (const plugin of plugins) {
             if (plugin.afterEmit) {
-                const beforeEmitPluginDiagnostics = plugin.afterEmit(program, options, this.emitHost, emitPlan) ?? [];
-                diagnostics.push(...beforeEmitPluginDiagnostics);
+                const afterEmitPluginDiagnostics = plugin.afterEmit(program, options, this.emitHost, emitPlan) ?? [];
+                diagnostics.push(...afterEmitPluginDiagnostics);
             }
         }
 
diff --git a/test/transpile/plugins/afterEmit.ts b/test/transpile/plugins/afterEmit.ts
@@ -6,10 +6,17 @@ const plugin: tstl.Plugin = {
         void program;
         void options;
         void emitHost;
+        void result;
 
-        for (const file of result) {
-            console.log(`File was written to disk: ${file.outputPath}`);
-        }
+        const diagnostic = {
+            category: ts.DiagnosticCategory.Message,
+            messageText: "After emit diagnostic message!",
+            code: 1234,
+            file: program.getSourceFiles()[0],
+            start: undefined,
+            length: undefined,
+        } satisfies ts.Diagnostic;
+        return [diagnostic];
     },
 };
 
diff --git a/test/transpile/plugins/plugins.spec.ts b/test/transpile/plugins/plugins.spec.ts
@@ -1,5 +1,6 @@
 import * as path from "path";
 import * as util from "../../util";
+import * as ts from "typescript";
 
 test("printer", () => {
     util.testModule``
@@ -160,3 +161,24 @@ test("beforeEmit plugin bundle", () => {
         expect(f.lua).toContain("-- Comment added by beforeEmit plugin");
     }
 });
+
+test("afterEmit plugin", () => {
+    const { diagnostics } = util.testModule`
+        console.log("Hello, World!");
+        [].push(1,2,3); // Use lualib code
+    `
+        .addExtraFile(
+            "extrafile.ts",
+            `
+                console.log("Hello, Mars!");
+            `
+        )
+        .setOptions({ luaPlugins: [{ name: path.join(__dirname, "afterEmit.ts") }] })
+        .getLuaResult();
+
+    // Expect to see the diagnostic returned by the plugin in the output
+    const diagnostic = diagnostics.find(d => d.code === 1234);
+    expect(diagnostic).toBeDefined();
+    expect(diagnostic?.category).toBe(ts.DiagnosticCategory.Message);
+    expect(diagnostic?.messageText).toContain("After emit");
+});

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,8 @@ export class Transpiler {`
`92`	`92`
`93`	`93`	`for (const plugin of plugins) {`
`94`	`94`	`if (plugin.afterEmit) {`
`95`		`- const beforeEmitPluginDiagnostics = plugin.afterEmit(program, options, this.emitHost, emitPlan) ?? [];`
`96`		`- diagnostics.push(...beforeEmitPluginDiagnostics);`
	`95`	`+ const afterEmitPluginDiagnostics = plugin.afterEmit(program, options, this.emitHost, emitPlan) ?? [];`
	`96`	`+ diagnostics.push(...afterEmitPluginDiagnostics);`
`97`	`97`	`}`
`98`	`98`	`}`
`99`	`99`