Implement Number.toFixed

Dimava · Dimava · commit 9676a5ddb71e · 2023-03-01T00:49:03.000+03:00
diff --git a/src/LuaLib.ts b/src/LuaLib.ts
@@ -58,6 +58,7 @@ export enum LuaLibFeature {
     NumberIsFinite = "NumberIsFinite",
     NumberIsNaN = "NumberIsNaN",
     NumberToString = "NumberToString",
+    NumberToFixed = "NumberToFixed",
     ObjectAssign = "ObjectAssign",
     ObjectDefineProperty = "ObjectDefineProperty",
     ObjectEntries = "ObjectEntries",
diff --git a/src/lualib/NumberToFixed.ts b/src/lualib/NumberToFixed.ts
@@ -0,0 +1,13 @@
+/// https://www.ecma-international.org/ecma-262/10.0/index.html#sec-number.prototype.tofixed
+export function __TS__NumberToFixed(this: number, fractionDigits?: number): string {
+    if (Math.abs(this) >= 1e21 || this !== this) {
+        return this.toString();
+    }
+    const f = Math.floor(fractionDigits ?? 0);
+    if (f < 0 || f > 100) {
+        throw "toFixed() digits argument must be between 0 and 100";
+    }
+    // throws "invalid format (width or precision too long)" if strlen > 99
+    // if (f < 80) return fmt; else try {return fmt} catch(_) { throw "toFixed() digits argument..." }
+    return string.format(`%.${f}f`, this);
+}
diff --git a/src/transformation/builtins/number.ts b/src/transformation/builtins/number.ts
@@ -20,6 +20,8 @@ export function transformNumberPrototypeCall(
             return params.length === 0
                 ? lua.createCallExpression(lua.createIdentifier("tostring"), [caller], node)
                 : transformLuaLibFunction(context, LuaLibFeature.NumberToString, node, caller, ...params);
+        case "toFixed":
+            return transformLuaLibFunction(context, LuaLibFeature.NumberToFixed, node, caller, ...params);
         default:
             context.diagnostics.push(unsupportedProperty(calledMethod.name, "number", expressionName));
     }
diff --git a/test/unit/builtins/numbers.spec.ts b/test/unit/builtins/numbers.spec.ts
@@ -69,6 +69,45 @@ test.each([
     util.testExpressionTemplate`(${value}).toString(2)`.expectToEqual(luaNativeSpecialNumString);
 });
 
+// frac=100 fails as result can't fit
+const toFixedFractions = [undefined, 0, 1, 1.23456, 2, Math.PI, 5, 10, 80];
+// val=x.5 fails as rounding differ
+const toFixedValues = [
+    -1,
+    0,
+    1,
+    1.2345678,
+    -20391,
+    3.1415,
+    Math.PI,
+    2.7182,
+    -34910.3,
+    1.45,
+    1.55,
+    1.444555,
+    1024,
+    1.2,
+    1e19,
+    1e22,
+];
+const toFixedPairs = toFixedValues.flatMap(value => toFixedFractions.map(frac => [value, frac] as const));
+test.each(toFixedPairs)("(%p).toFixed(%p)", (value, frac) => {
+    util.testExpressionTemplate`(${value}).toFixed(${frac})`.expectToMatchJsResult();
+});
+
+test.each([
+    [NaN, "(0/0)"],
+    [Infinity, "(1/0)"],
+    [-Infinity, "(-(1/0))"],
+])("%p.toFixed(2)", (value, luaNativeSpecialNum) => {
+    // Need to get the actual lua tostring version of inf/nan
+    // this is platform dependent so we can/should not hardcode it
+    const luaNativeSpecialNumString = util.testExpression`${luaNativeSpecialNum}.toString()`.getLuaExecutionResult();
+    // Cannot use expectToMatchJsResult because this actually wont be the same in JS in Lua
+    // TODO fix this in lualib/NumberToString.ts
+    util.testExpressionTemplate`(${value}).toFixed(2)`.expectToEqual(luaNativeSpecialNumString);
+});
+
 test.each(cases)("isNaN(%p)", value => {
     util.testExpressionTemplate`isNaN(${value} as any)`.expectToMatchJsResult();
 });

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@ export function transformNumberPrototypeCall(`
`20`	`20`	`return params.length === 0`
`21`	`21`	`? lua.createCallExpression(lua.createIdentifier("tostring"), [caller], node)`
`22`	`22`	`: transformLuaLibFunction(context, LuaLibFeature.NumberToString, node, caller, ...params);`
	`23`	`+ case "toFixed":`
	`24`	`+ return transformLuaLibFunction(context, LuaLibFeature.NumberToFixed, node, caller, ...params);`
`23`	`25`	`default:`
`24`	`26`	`context.diagnostics.push(unsupportedProperty(calledMethod.name, "number", expressionName));`
`25`	`27`	`}`