handle non-indexable types for lefthand value of instanceof (#837)

Chris Bajorin · chrisbajorin · web-flow · commit 9442bf690a2c · 2020-03-13T22:55:27.000+01:00
* handle non-indexable types for lefthand value of instanceof

* cleanup

Co-authored-by: Chris Bajorin &lt;chris@chrisbajorin.com&gt;
diff --git a/src/lualib/InstanceOf.ts b/src/lualib/InstanceOf.ts
@@ -8,7 +8,7 @@ function __TS__InstanceOf(this: void, obj: LuaClassInstance, classTbl: LuaClass)
         return !!classTbl[Symbol.hasInstance](obj);
     }
 
-    if (obj !== undefined) {
+    if (typeof obj === "object") {
         let luaClass = obj.constructor;
         while (luaClass !== undefined) {
             if (luaClass === classTbl) {
diff --git a/test/unit/classes/instanceof.spec.ts b/test/unit/classes/instanceof.spec.ts
@@ -49,6 +49,28 @@ test("null instanceof Class", () => {
     `.expectToMatchJsResult();
 });
 
+test("function instanceof Class", () => {
+    util.testFunction`
+        class myClass {}
+        const noop = () => {};
+        return (noop as any) instanceof myClass;
+    `.expectToMatchJsResult();
+});
+
+test("boolean instanceof Class", () => {
+    util.testFunction`
+        class myClass {}
+        return (false as any) instanceof myClass;
+    `.expectToMatchJsResult();
+});
+
+test("number instanceof Class", () => {
+    util.testFunction`
+        class myClass {}
+        return (5 as any) instanceof myClass;
+    `.expectToMatchJsResult();
+});
+
 test("instanceof export", () => {
     util.testModule`
         export class myClass {}

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ function __TS__InstanceOf(this: void, obj: LuaClassInstance, classTbl: LuaClass)`
`8`	`8`	`return !!classTbl[Symbol.hasInstance](obj);`
`9`	`9`	`}`
`10`	`10`
`11`		`- if (obj !== undefined) {`
	`11`	`+ if (typeof obj === "object") {`
`12`	`12`	`let luaClass = obj.constructor;`
`13`	`13`	`while (luaClass !== undefined) {`
`14`	`14`	`if (luaClass === classTbl) {`