Move lualibCompilation option out of public api

GlassBricks · GlassBricks · commit 8e8aa39d965a · 2022-02-27T12:04:31.000-08:00
diff --git a/build-lualib.js b/build-lualib.js
@@ -3,5 +3,5 @@ const path = require("path");
 const tstl = require("./src");
 
 const configFileName = path.resolve(__dirname, "src/lualib/tsconfig.json");
-const { diagnostics } = tstl.transpileProject(configFileName);
+const { diagnostics } = tstl.transpileLuaLibProject(configFileName);
 diagnostics.forEach(tstl.createDiagnosticReporter(true));
diff --git a/src/cli/information.ts b/src/cli/information.ts
@@ -19,7 +19,6 @@ export function getHelpString(): string {
 
     result += "Options:\n";
     for (const option of optionDeclarations) {
-        if (option.internal) continue;
         const aliasStrings = (option.aliases ?? []).map(a => "-" + a);
         const optionString = [...aliasStrings, "--" + option.name].join("|");
 
diff --git a/src/cli/parse.ts b/src/cli/parse.ts
@@ -10,7 +10,6 @@ interface CommandLineOptionBase {
     name: string;
     aliases?: string[];
     description: string;
-    internal?: boolean;
 }
 
 interface CommandLineOptionOfEnum extends CommandLineOptionBase {
@@ -84,12 +83,6 @@ export const optionDeclarations: CommandLineOption[] = [
         description: "An array of paths that tstl should not resolve and keep as-is.",
         type: "array",
     },
-    {
-        name: "luaLibCompilation",
-        description: "Internal. Specifies if this project is lualib source.",
-        type: "boolean",
-        internal: true,
-    },
 ];
 
 export function updateParsedConfigFile(parsedConfigFile: ts.ParsedCommandLine): ParsedCommandLine {
@@ -110,7 +103,7 @@ export function updateParsedConfigFile(parsedConfigFile: ts.ParsedCommandLine):
 
         for (const [name, rawValue] of Object.entries(parsedConfigFile.raw.tstl)) {
             const option = optionDeclarations.find(option => option.name === name);
-            if (!option && option !== "lualibCompilation") {
+            if (!option) {
                 parsedConfigFile.errors.push(cliDiagnostics.unknownCompilerOption(name));
                 continue;
             }
diff --git a/src/lualib/tsconfig.json b/src/lualib/tsconfig.json
@@ -10,7 +10,6 @@
     },
     "tstl": {
         "luaLibImport": "none",
-        "noHeader": true,
-        "luaLibCompilation": true
+        "noHeader": true
     }
 }
diff --git a/src/transpilation/index.ts b/src/transpilation/index.ts
@@ -40,6 +40,17 @@ export function transpileProject(
     return transpileFiles(parseResult.fileNames, parseResult.options, writeFile);
 }
 
+/** @internal */
+export function transpileLuaLibProject(configFileName: string): EmitResult {
+    const parseResult = parseConfigFileWithSystem(configFileName);
+    if (parseResult.errors.length > 0) {
+        return { diagnostics: parseResult.errors, emitSkipped: true };
+    }
+    parseResult.options.luaLibCompilation = true;
+
+    return transpileFiles(parseResult.fileNames, parseResult.options);
+}
+
 const libCache: { [key: string]: ts.SourceFile } = {};
 
 /** @internal */

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`},`
`11`	`11`	`"tstl": {`
`12`	`12`	`"luaLibImport": "none",`
`13`		`- "noHeader": true,`
`14`		`- "luaLibCompilation": true`
	`13`	`+ "noHeader": true`
`15`	`14`	`}`
`16`	`15`	`}`