Support shorthand property assignment in object literals (#183)

gakada · Perryvw · commit 8c6f4ef377aa · 2018-08-26T16:13:16.000+02:00
diff --git a/src/Transpiler.ts b/src/Transpiler.ts
@@ -1767,6 +1767,8 @@ export abstract class LuaTranspiler {
             if (ts.isPropertyAssignment(element)) {
                 const expression = this.transpileExpression(element.initializer);
                 properties.push(`${name} = ${expression}`);
+            } else if (ts.isShorthandPropertyAssignment(element)) {
+                properties.push(`${name} = ${name}`);
             } else {
                 throw TSTLErrors.UnsupportedKind("object literal element", element.kind, node);
             }
diff --git a/test/translation/lua/shorthandPropertyAssignment.lua b/test/translation/lua/shorthandPropertyAssignment.lua
@@ -0,0 +1 @@
+local f = function(x) return ({x = x}) end
diff --git a/test/translation/ts/shorthandPropertyAssignment.ts b/test/translation/ts/shorthandPropertyAssignment.ts
@@ -0,0 +1 @@
+const f = x => ({ x });
diff --git a/test/unit/objectLiteral.spec.ts b/test/unit/objectLiteral.spec.ts
@@ -10,9 +10,18 @@ export class ObjectLiteralTests {
     @TestCase(`{["a"]:3,b:"4"}`, `{["a"] = 3,b = "4"}`)
     @TestCase(`{["a"+123]:3,b:"4"}`, `{["a" .. 123] = 3,b = "4"}`)
     @TestCase(`{[myFunc()]:3,b:"4"}`, `{[myFunc()] = 3,b = "4"}`)
+    @TestCase(`{x}`, `{x = x}`)
     @Test("Object Literal")
     public objectLiteral(inp: string, out: string) {
         var lua = util.transpileString(`const myvar = ${inp};`)
         Expect(lua).toBe(`local myvar = ${out}`);
     }
+
+    @TestCase("3", 3)
+    @Test("Shorthand Property Assignment")
+    public ShorthandPropertyAssignment(input: string, expected: number): void {
+        const lua = util.transpileString(`const x = ${input}; const o = {x}; return o.x;`);
+        const result = util.executeLua(lua);
+        Expect(result).toBe(expected);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -1767,6 +1767,8 @@ export abstract class LuaTranspiler {`
`1767`	`1767`	`if (ts.isPropertyAssignment(element)) {`
`1768`	`1768`	`const expression = this.transpileExpression(element.initializer);`
`1769`	`1769`	properties.push(`${name} = ${expression}`);
	`1770`	`+ } else if (ts.isShorthandPropertyAssignment(element)) {`
	`1771`	+ properties.push(`${name} = ${name}`);
`1770`	`1772`	`} else {`
`1771`	`1773`	`throw TSTLErrors.UnsupportedKind("object literal element", element.kind, node);`
`1772`	`1774`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+local f = function(x) return ({x = x}) end`