Fixes class getters inheritance bug (#850)

chrisd08 · web-flow · commit 8ac51c340e2c · 2020-04-09T21:11:38.000+02:00
diff --git a/src/lualib/Descriptors.ts b/src/lualib/Descriptors.ts
@@ -50,7 +50,7 @@ function ____descriptorNewindex(this: any, key: string, value: any): void {
 
 // It's also used directly in class transform to add descriptors to the prototype
 function __TS__SetDescriptor(this: void, metatable: Metatable, prop: string, descriptor: PropertyDescriptor): void {
-    if (!metatable._descriptors) metatable._descriptors = {};
+    if (!rawget(metatable, "_descriptors")) metatable._descriptors = {};
     metatable._descriptors[prop] = descriptor;
 
     if (descriptor.get) metatable.__index = ____descriptorIndex;
diff --git a/test/unit/classes/accessors.spec.ts b/test/unit/classes/accessors.spec.ts
@@ -66,6 +66,26 @@ test("get accessor override accessor", () => {
     `.expectToMatchJsResult();
 });
 
+test("get accessor override accessor (multiple)", () => {
+    util.testFunction`
+        class Foo {
+            _foo = "foo";
+            get foo() { return this._foo; }
+        }
+        class Bar extends Foo {
+            _bar = "bar";
+            get foo() { return this._bar; }
+        }
+        class Baz extends Foo {
+            _baz = "baz";
+            get foo() { return this._baz; }
+        }
+        const bar = new Bar();
+        const baz = new Baz();
+        return bar.foo + baz.foo;
+    `.expectToMatchJsResult();
+});
+
 test("get accessor from interface", () => {
     util.testFunction`
         class Foo {
