Luajit unpack fix (#273)

hazzard993 · Perryvw · commit 800101584127 · 2018-11-08T10:34:20.000+01:00
* LuaJIT uses LuaTranspiler's spread

* Added some unit tests for spreading

* Stopped using prototype

* Removed Transpiler import
diff --git a/src/targets/Transpiler.JIT.ts b/src/targets/Transpiler.JIT.ts
@@ -39,4 +39,9 @@ export class LuaTranspilerJIT extends LuaTranspiler52 {
     public transpileDestructingAssignmentValue(node: ts.Expression): string {
         return `unpack(${this.transpileExpression(node)})`;
     }
+
+     /** @override */
+    public transpileSpreadElement(node: ts.SpreadElement): string {
+        return "unpack(" + this.transpileExpression(node.expression) + ")";
+    }
 }
diff --git a/test/unit/spreadElement.spec.ts b/test/unit/spreadElement.spec.ts
@@ -21,4 +21,20 @@ export class SpreadElementTest {
         const lua = util.transpileString(`[].push(...${JSON.stringify([1, 2, 3])});`, {luaTarget: LuaTarget.Lua51});
         Expect(lua).toBe("__TS__ArrayPush({}, unpack({1,2,3}));");
     }
+
+    @Test("Spread Element Lua 5.2")
+    public spreadElement52() {
+        const lua = util.transpileString(`[...[0, 1, 2]]`, {luaTarget: LuaTarget.Lua52, luaLibImport: "none"});
+        Expect(lua).toBe("{table.unpack({0,1,2})};");
+    }
+     @Test("Spread Element Lua 5.3")
+    public spreadElement53() {
+        const lua = util.transpileString(`[...[0, 1, 2]]`, {luaTarget: LuaTarget.Lua53, luaLibImport: "none"});
+        Expect(lua).toBe("{table.unpack({0,1,2})};");
+    }
+     @Test("Spread Element Lua JIT")
+    public spreadElementJIT() {
+        const lua = util.transpileString(`[...[0, 1, 2]]`, {luaTarget: LuaTarget.LuaJIT, luaLibImport: "none"});
+        Expect(lua).toBe("{unpack({0,1,2})};");
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -39,4 +39,9 @@ export class LuaTranspilerJIT extends LuaTranspiler52 {`
`39`	`39`	`public transpileDestructingAssignmentValue(node: ts.Expression): string {`
`40`	`40`	return `unpack(${this.transpileExpression(node)})`;
`41`	`41`	`}`
	`42`	`+`
	`43`	`+ /** @override */`
	`44`	`+ public transpileSpreadElement(node: ts.SpreadElement): string {`
	`45`	`+ return "unpack(" + this.transpileExpression(node.expression) + ")";`
	`46`	`+ }`
`42`	`47`	`}`